Skip to content

Add debugging symbols for important packages #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2019
Merged

Add debugging symbols for important packages #148

merged 1 commit into from
Oct 9, 2019

Conversation

gllghr
Copy link
Contributor

@gllghr gllghr commented Oct 9, 2019

Adds debug symbols for dependencies that are built in-house or are particularly important.

@gllghr
Copy link
Contributor Author

gllghr commented Oct 9, 2019

ab-pre-push: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/2298/console

prakashsurya
prakashsurya approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors delegte+

@gllghr
Copy link
Contributor Author

gllghr commented Oct 9, 2019

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 9, 2019

🔒 Permission denied

Existing reviewers: click here to make jgallag88 a reviewer

@gllghr
Copy link
Contributor Author

gllghr commented Oct 9, 2019

bors delegte+

@prakashsurya Can you re-deletage? The previous command has a typo.

@prakashsurya
Copy link
Contributor

prakashsurya commented Oct 9, 2019 •
edited
Loading

bors delegate+

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 9, 2019

✌️ jgallag88 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors bot added a commit that referenced this pull request Oct 9, 2019
@bors @gllghr
Merge #148
51d3a6f 
148: Add debugging symbols for important packages r=prakashsurya a=jgallag88

Adds debug symbols for dependencies that are built in-house or are particularly important.

Co-authored-by: John Gallagher <john.gallagher@delphix.com>
@prakashsurya
Copy link
Contributor

@jgallag88 feel free to reach out to @sebroy about being a GK for this repo.. I think it'd make sense to give you access.

@bors
Copy link
Contributor

bors bot commented Oct 9, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 7ab979e into delphix:master Oct 9, 2019
@gllghr gllghr mentioned this pull request Oct 21, 2019
Merged
@gllghr gllghr deleted the ddebs branch October 22, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashsurya prakashsurya prakashsurya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gllghr @prakashsurya