Merge master with develop #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#42) * DXE-683 Rename Select Connector - CouchBase * Version 1.1.1 (#31) * initial support for using non couchbase user through sudo * issue #22 - initial deployment, index support changes for backup ingestion, various fixes * partial work * cbbackupmgr working with sudo, bucket list in snapshot in JSON * version 1.0.2 * fixing uid/gid regex * version 1.0.3 - error messages fix * ver 1.0.3.1 * ver 1.0.3.2 - sudo for all * resync of xdcr and backupmgr OK * workinf with copy config * working with indexes - tested with backup only - ee, analytics removed from schema * add end of multi cluster * working multinode * checks added, upgrade added * version 1.1.0 build 0 * check mount points / doc updates * cbbackup exit code check * xdcr fixed for multi IP, and different scenarios * v1.1.1 build 1.1.0.2 * v1.1.0 build 1.1.0.2 * version 1.1.1 - added field for hostname * Issue #32 - multinode start * version 1.1.2 * Set theme jekyll-theme-minimal * doc fixes * new logo * proper style * docs with multi node Co-authored-by: Marcin Przepiorowski <marcin@delphix.com> Co-authored-by: ayesharustgi-delphix <88486745+ayesharustgi-delphix@users.noreply.github.com> * DXE-988 Couchbase - VDB failed to enable (#36) * CE-59 Couchbase Plugin : Conversion of python2 to python3 (#38) * CE-332 Disable python2.7 unit tests on couchbase repository (#41) * unit test upgrade to python3.8 PR URL: https://www.github.com/delphix/couchbase-plugin/pull/41 * unit test upgrade to python3.8 * removing python2.7 tests * fixing python version to python3.8 for pytest * disabling unit tests in github workflows * reverting changes in test --------- Co-authored-by: atyagi <ankur.tyagi@delphix.com> Co-authored-by: Marcin Przepiorowski <pioro1@gmail.com> Co-authored-by: Marcin Przepiorowski <marcin@delphix.com>
* CE-235 Enable CodeQL on Couchbase Repository PR URL: https://www.github.com/delphix/couchbase-plugin/pull/45 * CE-339 Addition of security tests in codeQL
* CE-341 Fix codeQL PR URL: https://www.github.com/delphix/couchbase-plugin/pull/46 * CE-341 Fix codeQL
* * Issue #32 - multinode start * Set theme jekyll-theme-minimal * add end of multi cluster * cbbackup exit code check * cbbackupmgr working with sudo, bucket list in snapshot in JSON * check mount points / doc updates * checks added, upgrade added * doc fixes * docs with multi node * fixing uid/gid regex * initial support for using non couchbase user through sudo * issue #22 - initial deployment, index support changes for backup ingestion, various fixes * new logo * partial work * proper style * resync of xdcr and backupmgr OK * v1.1.0 build 1.1.0.2 * v1.1.1 build 1.1.0.2 * ver 1.0.3.1 * ver 1.0.3.2 - sudo for all * version 1.0.2 * version 1.0.3 - error messages fix * version 1.1.0 build 0 * version 1.1.1 - added field for hostname * version 1.1.2 * workinf with copy config * working multinode * working with indexes - tested with backup only - ee, analytics removed from schema * xdcr fixed for multi IP, and different scenarios CE-59 Couchbase Plugin : Conversion of python2 to python3 (#38) Co-authored-by: Marcin Przepiorowski <marcin@delphix.com> Co-authored-by: ayesharustgi-delphix <88486745+ayesharustgi-delphix@users.noreply.github.com> DXE-683 Rename Select Connector - CouchBase DXE-988 Couchbase - VDB failed to enable (#36) Version 1.1.1 (#31) security fix draft * CE-340 Code changes to mask password in "ps" using expect utility PR URL: https://www.github.com/delphix/couchbase-plugin/pull/47 * code update * code update * removing commented code
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
* CE-509 REST API implementation for cluster-init CE-510 REST API implementation for xdcr-setup CE-511 REST API implementation for setting-cluster CE-518 index creation inside scope support CE-519 snapshot fails with backup restore failure CE-520 status check of replication fails in xdcr dsource type CE-521 cluster init fails when couchbase instance is recreated on a machine CE-523 bucket-flush command fix CE-525 server-add command fix VDB creation fix for couchbase version 7.1.3 PR URL: https://www.github.com/delphix/couchbase-plugin/pull/54 * CE-543 scope and collection pre-creation for xdcr dsource type * CE-544 fix XDCR delete configuration * CE-545 code hardening * CE-546 plugin version upgrade * CE-547 CodeQL fixes * CE-547 CodeQL fixes * CE-550 Changes in cluster-init and server-add for couchbase 7.1.1 * CE-550 Changes in cluster-init and server-add for couchbase 7.1.1 * CE-550 Changes in cluster-init and server-add for couchbase 7.1.1
* CE-554 Implement precommit checks in couchbase repo PR URL: https://www.github.com/delphix/couchbase-plugin/pull/56 * CodeQL fixes * CodeQL fixes
| command = CommandFactory.change_permission(directory_path) | ||
| utilities.execute_bash(self.connection, command) | ||
|
|
||
| command_output, std_err, exit_code = self.run_os_command( |
Check warning
Code scanning / CodeQL
Variable defined multiple times
| command = CommandFactory.change_permission(directory_path) | ||
| utilities.execute_bash(self.connection, command) | ||
|
|
||
| command_output, std_err, exit_code = self.run_os_command( |
Check warning
Code scanning / CodeQL
Variable defined multiple times
| command = CommandFactory.change_permission(directory_path) | ||
| utilities.execute_bash(self.connection, command) | ||
|
|
||
| command_output, std_err, exit_code = self.run_os_command( |
Check warning
Code scanning / CodeQL
Variable defined multiple times
| "Changing permission of directory path {}".format(directory_path) | ||
| ) | ||
|
|
||
| command_output, std_err, exit_code = self.run_os_command( |
Check notice
Code scanning / CodeQL
Unused local variable
| "Changing permission of directory path {}".format(directory_path) | ||
| ) | ||
|
|
||
| command_output, std_err, exit_code = self.run_os_command( |
Check notice
Code scanning / CodeQL
Unused local variable
| "Changing permission of directory path {}".format(directory_path) | ||
| ) | ||
|
|
||
| command_output, std_err, exit_code = self.run_os_command( |
Check notice
Code scanning / CodeQL
Unused local variable
Comment on lines
+70
to
+71
| # if analytics_service: | ||
| # additional_service = additional_service + ",analytics" |
Check notice
Code scanning / CodeQL
Commented-out code
* CE-541 Ingestion from multiple full backups PR URL: https://www.github.com/delphix/couchbase-plugin/pull/60 * Deleting test folder
…ual pre-snapshot failing (#63) CE-577 Couchbase 1.30 >> Ingestion from multiple full backups >> Pre-snapshot failing PR URL: https://www.github.com/delphix/couchbase-plugin/pull/63
… size should be greater or equal to 100MB (#64) PR URL: https://www.github.com/delphix/couchbase-plugin/pull/64
* CE-574 Upgrade Logic PR URL: https://www.github.com/delphix/couchbase-plugin/pull/61 * plugin version update
… permissions (#68) * CE-633 Couchbase Plugin: Dsource sizing not working due to filesystem permissions PR URL: https://www.github.com/delphix/couchbase-plugin/pull/68 * CE-633 Couchbase Plugin: Dsource sizing not working due to filesystem permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Testing Done