This repository was archived by the owner on Apr 14, 2018. It is now read-only.
Docker Registry v1 and v2 #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -20,6 +20,11 @@ docker_registry_dir: /opt/docker-registry | |||
| docker_registry_port: 5000 | |||
| docker_registry_vhost_name: "registry registry.yourdomain.local" | |||
|
|
|||
| docker_registry_2_enable: true | |||
| docker_registry_2_dir: /opt/docker-registry | |||
There was a problem hiding this comment.
Is it a problem that the v1 and v2 registries are both enabled by default and are both using the same storage dir?
There was a problem hiding this comment.
Good catch, I'll update
|
@cmheisel Really sorry to do this since you've already re-worked your change, but... In my comments in #7, I was merely asking what you thought about how to handle the v1/v2 Registry upgrade logistics. Looking at the two diffs and thinking about the longer-term implications, I kind of like the diff from #7 better. If we're going to implement a v2 registry, I think the v1 registry can be removed. Can we re-open #7, update it with the README changes, then I'll merge it? Thanks and sorry for any miscommunications on my part. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Docker registry v2
Retrains Docker registry v1
Updated README