feat: add VDB group update and tag management with acceptance tests #126
Conversation
|
Linking the Issue #102 |
elima-sugunan
requested review from
arunskurian,
gmanhas23,
Uddipaan-Hazarika and
elima-sugunan
| @@ -35,18 +35,38 @@ func resourceVdbGroup() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| }, | |||
| }, | |||
| "tags": { | |||
| Type: schema.TypeList, | |||
| Optional: true, | |||
There was a problem hiding this comment.
We will need computed:true here, as without that, it will detect UIPs in case of auto-tagging.
| updateVdbGroupReq.SetVdbIds(toStringArray(d.Get("vdb_ids"))) | ||
| } | ||
|
|
||
| _, httpRes, err := client.VDBGroupsAPI.UpdateVdbGroupById(ctx, vdbGroupId).UpdateVDBGroupParameters(updateVdbGroupReq).Execute() |
There was a problem hiding this comment.
It would be better to add the polling logic here. The api call looks like async process, so completion of this update api call doesn't guarantee a working vdb_group. So it would be better if we could poll till we have a status equivalent RUNNING.
| } | ||
| } | ||
|
|
||
| if d.HasChange("tags") { |
There was a problem hiding this comment.
This update logic looks too complex and I am not sure if we really want a lookup logic around. As of now there are no tag update api. we explicitly need to delete the old one and create a new one.
The logic here ultimately does the same api call and there are no data retrieval involved, i dont see lookup being advantageous. Rather we can simply remove the old tags and create the new ones if there are changes.
I may be overlooking something so would really want other's opinions on it.
There was a problem hiding this comment.
Since tags are used for managing access, there could be potential race conditions when tags that should not be deleted get deleted as part of the update if we take the approach of deleting and recreating all tags?
internal/provider/utility.go
Outdated
| @@ -212,14 +212,14 @@ func flattenDSourceHooks(hooks []dctapi.Hook, oldList []dctapi.SourceOperation) | |||
|
|
|||
| func flattenTags(tags []dctapi.Tag) []interface{} { | |||
| if tags != nil { | |||
| returnedTags := make([]interface{}, len(tags)) | |||
| result := make([]interface{}, len(tags)) | |||
There was a problem hiding this comment.
I think this is just refactoring with no functional usage.
|
Also updating the PR and redirecting the incoming change sets to develop. |
sumedhbala-delphix
force-pushed
the
feature/vdb-group-tag-enhancements-new
branch
from
b1acca3 to
afd41c2
Compare
Add VDB Group Update and Tag Management with Acceptance Tests
Overview
This PR introduces enhancements to the VDB group resource, focusing on two key areas:
1. VDB Group Updates
2. Tag Management
Testing
Note: All changes were generated by claude3.7