Skip to content

Release/1.0.0 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 83 commits into from
Mar 30, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
690363b
removed unused interface
janniclas Mar 12, 2019
9b6950a
extended table all component with the possibility to hide some contro…
janniclas Mar 12, 2019
66536dd
on click hanlder for cytoscape nodes showing a first version of the i…
janniclas Mar 12, 2019
bdd5ead
extended graph view to enable display of subnets only. dependent on o…
janniclas Mar 12, 2019
771b7f8
log cleanup
janniclas Mar 12, 2019
071b1b7
not displaying drag and drop functionality in graph view if we view a…
janniclas Mar 12, 2019
50ff0ec
Merge branch 'develop' into feature/instanceDetails
janniclas Mar 14, 2019
05b856e
restructured the logic code of the notification center to the data so…
janniclas Mar 14, 2019
5dae644
Merge branch 'feature/checkUserIsAdmin' into feature/instanceDetails
janniclas Mar 16, 2019
40e11fc
updated info center to support filtering the events after instance id…
janniclas Mar 16, 2019
ad66657
integrating info center in instance details page
janniclas Mar 16, 2019
633d5fe
Merge pull request #135 from delphi-hub/release/0.9.5
Ayybeeshafi Mar 18, 2019
53ecbd9
added notification center to table overview
janniclas Mar 19, 2019
ca3ef5d
fixed test cases
janniclas Mar 19, 2019
4f4471e
Merge branch 'develop' into feature/instanceDetails
janniclas Mar 19, 2019
801a916
version bump
janniclas Mar 19, 2019
2eb0d03
fixed linting error missing semicolon
janniclas Mar 19, 2019
b91fb83
fixed incorrect data binding
janniclas Mar 19, 2019
ea805f2
using return as observable instead of manually creating a new observa…
janniclas Mar 19, 2019
01c48a2
added previous state to state update, to enable calculation of change…
janniclas Mar 21, 2019
5181e80
added first version of an event service to conviniently provide acces…
janniclas Mar 21, 2019
92fcff3
integrated new event service in data source for info center
janniclas Mar 21, 2019
ee5262c
unsubscribing from paginator and sort...
janniclas Mar 21, 2019
21c72b9
fixed pagination
janniclas Mar 21, 2019
c53e742
Merge pull request #136 from delphi-hub/feature/instanceDetails
ishwaryamamidi Mar 23, 2019
652da99
ishwaryamamidi Mar 23, 2019
9a7f1a9
ishwaryamamidi Mar 24, 2019
8a244b1
ishwaryamamidi Mar 24, 2019
b3f0403
Added comments to GET users methods
ishwaryamamidi Mar 24, 2019
2b163d8
removed uncommented line of code
janniclas Mar 26, 2019
fa1c249
Merge branch 'develop' into feature/eventModel
janniclas Mar 26, 2019
4c2b0be
removed unneeded logs
janniclas Mar 26, 2019
1d8d0f0
custom details message on instance state change in notification center
janniclas Mar 26, 2019
66b9bb9
removed todo finished in last commit
janniclas Mar 26, 2019
e5ee663
changing action type to auth action at the new api endpoints
janniclas Mar 26, 2019
c744a13
fixed linting issues
janniclas Mar 26, 2019
bae0903
not displaying user management component for non admin users
janniclas Mar 26, 2019
8bef2c3
removed unneeded logs
janniclas Mar 26, 2019
3724e66
fixed invalid return type of delete user
janniclas Mar 26, 2019
2fa1040
fixed long overdue socket message parse error
janniclas Mar 26, 2019
e253c6e
linting errors
janniclas Mar 26, 2019
f2e80fa
removed test cases with dependencies to the authorization service, be…
janniclas Mar 26, 2019
dd586c4
Merge pull request #137 from delphi-hub/feature/newUserMgmt
janniclas Mar 26, 2019
296f639
Merge branch 'develop' into feature/eventModel
janniclas Mar 27, 2019
7725e58
Added delete label feature
Naveenkumar27 Mar 27, 2019
e41978d
Fixed lint error
Naveenkumar27 Mar 27, 2019
25b0175
Update InstanceRegistryController.scala
janniclas Mar 27, 2019
6b88427
Aligned "add user" button in user management
Naveenkumar27 Mar 28, 2019
a571d12
Updated vulnerable dependencies
Mar 28, 2019
906830b
Merge pull request #138 from delphi-hub/feature/eventModel
ishwaryamamidi Mar 28, 2019
7d9af0c
Merge branch 'develop' into feature/dependencyUpgrade
Mar 28, 2019
23444a6
Alligned some UI issues in instance details page
ishwaryamamidi Mar 28, 2019
248fca8
actually sending user token to validate the different access levels t…
janniclas Mar 28, 2019
9eaf3ff
Changed some UI issues in table view
ishwaryamamidi Mar 28, 2019
9448368
hiding all control elements for not admin users
janniclas Mar 28, 2019
fd1c29b
User management and table view changes
ishwaryamamidi Mar 28, 2019
bbd62a8
logout functionality added
janniclas Mar 28, 2019
004e362
Merge pull request #140 from delphi-hub/feature/dependencyUpgrade
johannesduesing Mar 28, 2019
702cf27
updated dependencies
janniclas Mar 28, 2019
bec31e3
fixed logout button
janniclas Mar 28, 2019
70c355c
ishwaryamamidi Mar 28, 2019
441364e
fixed test cases to not crash if dependent on authorization service.
janniclas Mar 28, 2019
90ddd14
Merge branch 'develop' into hotfix/userAccessLevelFix
janniclas Mar 28, 2019
65a490f
fixed token parsing to be compatible with ir v 1.0
janniclas Mar 28, 2019
3d8a63a
ishwaryamamidi Mar 28, 2019
0dc67a8
ishwaryamamidi Mar 28, 2019
813c17b
fixed mistaketly changed code
janniclas Mar 28, 2019
f2e9669
Merge branch 'develop' into feature/beautify
janniclas Mar 28, 2019
cc86941
Fixed bug that removed whole instance from table
Mar 28, 2019
4044e7d
fixed bug that an error is thrown if no name is proided to add dialog
janniclas Mar 28, 2019
e392310
fixed nullpointer in notification center in comp type comparison afte…
janniclas Mar 28, 2019
a004d09
Merge remote-tracking branch 'origin/develop' into feature/labelDelete
Mar 28, 2019
3b90bc1
Merge pull request #139 from delphi-hub/feature/labelDelete
janniclas Mar 28, 2019
dfc8530
merged develop
janniclas Mar 28, 2019
25e3019
merged develop branch and fixed test case
janniclas Mar 28, 2019
6815194
removed duplicated add instance button
janniclas Mar 29, 2019
aedecd9
Merge pull request #141 from delphi-hub/hotfix/userAccessLevelFix
janniclas Mar 29, 2019
1b825d9
Merge pull request #142 from delphi-hub/feature/beautify
janniclas Mar 30, 2019
4cf61c5
Merge branch 'master' into release/1.0.0
janniclas Mar 30, 2019
09f6f07
version bump
janniclas Mar 30, 2019
a54c480
fixed bug which didn't show add instance button if no instance exists
janniclas Mar 30, 2019
a902057
fixed issue which caused graph view to crash after deleting an element
janniclas Mar 30, 2019
d2e60a6
removed test case since in the new html structure there is a conditio…
janniclas Mar 30, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added previous state to state update, to enable calculation of change…
…s to elements
  • Loading branch information
janniclas committed Mar 21, 2019
commit 01c48a22faae69467e002ac0dd0773e6e3483bbd
10 changes: 1 addition & 9 deletions client/src/app/model/model.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,15 +102,7 @@ export class ModelService {
* instance stored in the state.
*/
public getObservableForInstances() {
return new Observable<InstanceChange>((observer) => {
this.instanceSubject.subscribe(observer);
observer.next(this.instanceSubject.value);

return () => {
// TODO: see console log
console.log('observer completed, implement unsubscribe logic !');
};
});
return this.instanceSubject.asObservable();
}

/**
Expand Down
24 changes: 15 additions & 9 deletions client/src/app/model/store.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export interface State {
}
export interface StateUpdate {
state: State;
prevState: State;
change: Change;
}
export interface Change {
Expand Down Expand Up @@ -89,7 +90,7 @@ export class StoreService {
}

constructor() {
this.stateUpdateSubject = new BehaviorSubject<StateUpdate>({state: EMPTY_STATE, change: {type: Actions.NONE}});
this.stateUpdateSubject = new BehaviorSubject<StateUpdate>({state: EMPTY_STATE, prevState: EMPTY_STATE, change: {type: Actions.NONE}});
}

/**
Expand All @@ -116,21 +117,22 @@ export class StoreService {
const newState: State = instances.reduce((accumulator: State, currentValue: Instance) => {
return StoreService.addNewInstanceToState(accumulator, currentValue);
}, EMPTY_STATE);

const changed = calculateDiff ? StoreService.stateHasChanged(this.stateUpdateSubject.value.state, instances) : true;
const prevState = this.stateUpdateSubject.value.state;
const changed = calculateDiff ? StoreService.stateHasChanged(prevState, instances) : true;

if (changed) {
this.stateUpdateSubject.next({state: newState, change: {type: Actions.ADD, elements: instances}});
this.stateUpdateSubject.next({state: newState, prevState: prevState, change: {type: Actions.ADD, elements: instances}});
}
}

/**
* Adds the given @param instance to the state.
*/
public addInstanceToState(instance: Instance) {
const newState = StoreService.addNewInstanceToState(this.stateUpdateSubject.value.state, instance);
const prevState = this.stateUpdateSubject.value.state;
const newState = StoreService.addNewInstanceToState(prevState, instance);
// maybe calculate diff before
this.stateUpdateSubject.next({state: newState, change: {type: Actions.ADD, elements: [instance]}});
this.stateUpdateSubject.next({state: newState, prevState: prevState, change: {type: Actions.ADD, elements: [instance]}});
}

/**
Expand All @@ -139,20 +141,24 @@ export class StoreService {
*/
public changeInstancesState(instances: Array<Instance>) {
let newState: State;
const prevState = this.stateUpdateSubject.value.state;
for (const instance of instances) {
newState = StoreService.addNewInstanceToState(this.stateUpdateSubject.value.state, instance);
}
// maybe calculate diff before
this.stateUpdateSubject.next({state: newState, change: {type: Actions.CHANGE, elements: instances}});
this.stateUpdateSubject.next({state: newState, prevState: prevState, change: {type: Actions.CHANGE, elements: instances}});
}

/**
* Removes the given @param instance from the state.
*/
public removeFromState(instance: Instance) {
const newState = StoreService.removeInstanceFromState(this.stateUpdateSubject.value.state, instance);

const prevState = this.stateUpdateSubject.value.state;
const newState = StoreService.removeInstanceFromState(prevState, instance);

// maybe calculate diff before
this.stateUpdateSubject.next({state: newState, change: {type: Actions.DELETE, elements: [instance]}});
this.stateUpdateSubject.next({state: newState, prevState: prevState, change: {type: Actions.DELETE, elements: [instance]}});
}

}