Upgrade to OPAL 4.0.0 #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wise there are runtime errors
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Oct 21, 2021
|
Closed as this functionality is now part of the redesign proposed in #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the dependency to the OPAL framework from
1.0.0to4.0.0. Changes were done mostly in code that is not currently used in the crawler (ie the CallGraph generation / unresolved method matching), but functionality should be equivalent. However, i am not able to verify that, as there is no tests available for these functions yet.Surprisingly, the code related to Hermes stayed pretty much the same, and the tests still work as intended.
Also in this PR: Changed
http://tohttps://in a couple of test files to make them work again.