Skip to content

Adapted registry interface to newest API version #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

johannesduesing
Copy link

Reason for this PR
This PR changes the Delphi registry HTTP interface in order to be more REST-like (as discussed here). The status report endpoints that each of the Delphi components calls have to be adapted to the new API specification.

Changes in this PR

  • Adapted URLs that are being called to the new API schema

Related PRs
The same has been done for the

@johannesduesing johannesduesing self-assigned this Jan 22, 2019
@ghost ghost added the review label Jan 22, 2019
bhermann
bhermann previously approved these changes Feb 4, 2019
Copy link
Member

@bhermann bhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov-io
Copy link

Codecov Report

Merging #36 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #36      +/-   ##
==========================================
- Coverage     8.06%   8.04%   -0.03%     
==========================================
  Files           45      45              
  Lines         1178    1181       +3     
  Branches        33      34       +1     
==========================================
  Hits            95      95              
- Misses        1083    1086       +3
Impacted Files Coverage Δ
.../crawler/instancemanagement/InstanceRegistry.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b8daf...9c8e200. Read the comment docs.

@bhermann bhermann merged commit 1ac5941 into develop Feb 7, 2019
@ghost ghost removed the review label Feb 7, 2019
@bhermann bhermann deleted the feature/newRegistryAPI branch February 7, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants