Skip to content

Introduced JWT based authorization for registry communication #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2019

Conversation

johannesduesing
Copy link

Reason for this PR
The instance registry will require authentication based on JSON Web Tokens (JWTs) soon (as described here). The components of the Delphi system have to be able to generate valid JWTs based on a secret that is either passed in an environment variable or in the configuration file. They have to add the encoded token in the Authorization header of every HTTP request issued to the registry. For more information see the respective issue.

Changes in this PR

  • The Crawler is now able to generate valid JWTs based on a secret specified in an environment variable (using HS256 signature algorithm)
  • The Crawler sends an encoded valid JWT with every request issued to the registry

@johannesduesing johannesduesing self-assigned this Jan 3, 2019
@ghost ghost added the review label Jan 3, 2019
@codecov-io
Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #35 into develop will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #35      +/-   ##
==========================================
- Coverage     8.12%   8.06%   -0.07%     
==========================================
  Files           44      45       +1     
  Lines         1169    1178       +9     
  Branches        27      33       +6     
==========================================
  Hits            95      95              
- Misses        1074    1083       +9
Impacted Files Coverage Δ
.../crawler/instancemanagement/InstanceRegistry.scala 0% <0%> (ø) ⬆️
...wt/delphi/crawler/authorization/AuthProvider.scala 0% <0%> (ø)
...a/de/upb/cs/swt/delphi/crawler/Configuration.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9bdabb...9331aee. Read the comment docs.

@bhermann bhermann merged commit e9b8daf into develop Jan 4, 2019
@ghost ghost removed the review label Jan 4, 2019
@bhermann bhermann deleted the feature/authentication branch January 4, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants