Skip to content

Adapt Crawler to latest changes of the registry interface #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

johannesduesing
Copy link

Reason for this PR
The interface of the instance registry has been changed lately. The reason for this was to better support the requirements of the Delphi-Management state management. The relevant change is:

  • The attributes linksTo: List[InstanceLink] and linksFrom: List[InstanceLink] have been added to the Instance class

This PR adapts the Crawler to this change. The same has been done for the WebApp and WebApi.

Changes

  • Added file InstanceLink.scala containing the JSON support
  • Added new attributes to Instance

linksTo and linksFrom are now attributes of instances
@codecov-io
Copy link

Codecov Report

Merging #33 into develop will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #33     +/-   ##
=========================================
- Coverage     8.22%   8.12%   -0.1%     
=========================================
  Files           43      44      +1     
  Lines         1155    1169     +14     
  Branches        34      27      -7     
=========================================
  Hits            95      95             
- Misses        1060    1074     +14
Impacted Files Coverage Δ
...a/de/upb/cs/swt/delphi/crawler/Configuration.scala 0% <ø> (ø) ⬆️
...lphi/crawler/instancemanagement/InstanceLink.scala 0% <0%> (ø)
.../crawler/instancemanagement/InstanceRegistry.scala 0% <0%> (ø) ⬆️
...t/delphi/crawler/instancemanagement/Instance.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e72f48...abac46b. Read the comment docs.

@bhermann bhermann merged commit d9bdabb into develop Nov 24, 2018
@ghost ghost removed the review label Nov 24, 2018
@bhermann bhermann deleted the feature/linksAsAttributes branch November 24, 2018 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants