Skip to content

Adapt crawler to latest API change in registry #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2018

Conversation

johannesduesing
Copy link

Reason for this PR
The API of the Instance Registry has been change lately. The goal was to support new UI requirements. The relevant changes are:

  • /matchingInstance and /matchingResult now require an additional parameter containing the caller-Id
  • The Instance now has a new attribute called labels of type List[String]

This PR adapts the crawler to support the new API version.

Changes

  • Added attribute labels: List[String] to case class Instance
  • Changed calls to /matchingInstance and /matchingResult to post the parameter callerId as well

@johannesduesing johannesduesing self-assigned this Nov 8, 2018
@ghost ghost added the review label Nov 8, 2018
@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #30 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #30      +/-   ##
==========================================
- Coverage     8.23%   8.22%   -0.02%     
==========================================
  Files           43      43              
  Lines         1153    1155       +2     
  Branches        27      34       +7     
==========================================
  Hits            95      95              
- Misses        1058    1060       +2
Impacted Files Coverage Δ
...a/de/upb/cs/swt/delphi/crawler/Configuration.scala 0% <ø> (ø) ⬆️
.../crawler/instancemanagement/InstanceRegistry.scala 0% <0%> (ø) ⬆️
...t/delphi/crawler/instancemanagement/Instance.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecc237...d67329a. Read the comment docs.

@bhermann bhermann merged commit 6e72f48 into develop Nov 8, 2018
@ghost ghost removed the review label Nov 8, 2018
@bhermann bhermann deleted the feature/newMatchingInterface branch November 8, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants