Implementation of the new IR API #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented case distinction between inside docker container / outside docker container. TODO: Use ReportFailure where appropriate.
…of a regular stop.
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## develop #26 +/- ##
==========================================
- Coverage 8.6% 8.18% -0.42%
==========================================
Files 43 43
Lines 1092 1148 +56
Branches 26 28 +2
==========================================
Hits 94 94
- Misses 998 1054 +56
Continue to review full report at Codecov.
|
bhermann
approved these changes
Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the crawler to be compatible to the new instance registry API. This means that it will now check whether an environment variable named INSTANCE_ID is defined. If this is the case, the crawler will use the endpoints /reportStart, /reportStop & /reportFailure instead of /register and /deregister. If the variable is not defined, the old endpoints will be used.