-
Notifications
You must be signed in to change notification settings - Fork 9
The Crawler now registers itself at the instance registry #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6e6a675
Implemented a Preflight check connecting to the Instance Registry
7edf235
ElasticSearch instance can now be set to the one responded by th IR
ab2bce3
Included client API code from swagger to connect to IR
bb3d605
Used akka http to call IR instead of outdated spray http
c2c9801
Removed unused swagger code, used logger where println was used
3439480
Crawler can now get elastic search ip from IR
bf368e8
Cleaned up unused dependencies, fixed some minor bugs
ba109f6
Crawler now reads its assigned IP after registration at the Instance …
c67ce57
Made posting matching-result work by storing the matched ElasticSearc…
51fe0b1
Crawler is now deregistering itself from the Instance Registry on shu…
d9111f6
Merge remote-tracking branch 'origin/develop' into feature/instancere…
0d6b1a9
Code style cleanup
18a71a0
Restored setting of Hermes config, fails on Linux and Windows
cc45162
CodeStyle: Replaced .get with .getOrElse
81e8482
Moved default host to val, removed unused resolver/unnecessary condition
10fb5bc
Made class 'Instance' not use Options anymore
1e8ec5e
Fixed shutdown hook not being triggered, fixed port of IR
b2458f0
Better handling of getMatchingInstance returning 404
c2d86be
Adapted IR communication to use new attribute names
3372a89
CodeStyle: Replaced if-else if with match-case
d66bf31
Merge branch 'develop' into feature/instanceregistry
44462af
Fixed merge error (missing comma)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Code style cleanup
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,13 +46,13 @@ object ElasticReachablePreflightCheck extends PreflightCheck { | |
val f = (client.execute { | ||
nodeInfo() | ||
} map { i => { | ||
if(configuration.usingInstanceRegistry) InstanceRegistry.sendMatchingResult(true, configuration) | ||
if(configuration.usingInstanceRegistry) InstanceRegistry.sendMatchingResult(isElasticSearchReachable = true, configuration) | ||
Success(configuration) | ||
} | ||
} recover { case e => { | ||
if(configuration.usingInstanceRegistry) InstanceRegistry.sendMatchingResult(false, configuration) | ||
} recover { case e => | ||
if(configuration.usingInstanceRegistry) InstanceRegistry.sendMatchingResult(isElasticSearchReachable = false, configuration) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having the condition at all places where it is used can be dangerous. |
||
Failure(e) | ||
} | ||
|
||
}).andThen { | ||
case _ => client.close() | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.