Skip to content

Feature/call graph generation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 29, 2018

Conversation

almacken
Copy link
Contributor

No description provided.

almacken added 12 commits June 21, 2018 15:11
This implementation isn't fast or stable, and should not be considered finished.
Large amounts of requests are still causing errors or being dropped because of problems handling any deviation from the simplest POM format.
# Conflicts:
#	build.sbt
#	src/main/scala/de/upb/cs/swt/delphi/crawler/discovery/maven/MavenIdentifier.scala
#	src/main/scala/de/upb/cs/swt/delphi/crawler/storage/ElasticActor.scala
# Conflicts:
#	build.sbt
#	src/main/scala/de/upb/cs/swt/delphi/crawler/preprocessing/PreprocessingDispatchActor.scala
@ghost ghost assigned almacken Aug 23, 2018
@ghost ghost added the review label Aug 23, 2018
@almacken
Copy link
Contributor Author

I'm currently trying to fix the errors in this version and improve code quality.
I'll add another comment when this branch is ready to merge.

@almacken
Copy link
Contributor Author

Many of the bugs I'm fixing are caused by usage of Elastic4s' ElasticClient class, which does not appear to actually exist in the copy of the library I have on my machine.
I'm currently replacing usages of it with HttpClient, and updating some code to support differences in return types.

@almacken
Copy link
Contributor Author

The Travis CI build doesn't seem able to resolve references to either ElasticClient or HttpClient.
Does anyone know what the issue here is?

@ghost ghost assigned bhermann Aug 25, 2018
@bhermann
Copy link
Member

Please try again in your environment with activated auto-import (see email).

@almacken
Copy link
Contributor Author

I think this branch is ready to be merged, but the Codacy check is no longer running.

@almacken
Copy link
Contributor Author

Alright, I think that's all the changes I'm going to make.
This branch is ready to be merged.

@bhermann
Copy link
Member

Thanks Alex! I'll have look tomorrow. Just made it home after some travel chaos.

@bhermann bhermann merged commit 3a1b456 into delphi-hub:develop Aug 29, 2018
@ghost ghost removed the review label Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants