Added instructions for running in Docker without a Git checkout #17
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @z0u, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've enhanced the documentation for mcp-server-trello by adding comprehensive instructions on how to run the server directly within a Docker container. This change is particularly beneficial for users who prefer to avoid a local Git checkout, offering a more secure and streamlined setup process. The new guide covers the necessary Docker commands and configuration details to get the server up and running efficiently.
Highlights
- Documentation Update: I've updated the
README.mdto include a new section detailing how to runmcp-server-trellousing Docker. This includes thedocker runcommands and the necessary configuration for themcpServers.trelloentry in the Claude Desktop config file. - Docker Integration: The new Docker instructions leverage named volumes (
npx-cache-20andnode-modules-cache-20) to efficiently cache Node modules, improving performance for subsequent runs. It also outlines how to passTRELLO_API_KEYandTRELLO_TOKENas environment variables.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for running the mcp-server-trello package using Docker without requiring a local Git checkout. The change provides an alternative Docker-based installation method for users who prefer containerized execution for security reasons.
- Added Docker configuration example to the README
- Included named volume caching for npm and node modules to improve performance
- Modified the introductory text to better reference the Claude Desktop configuration
README.md
Outdated
| ### Quick Start with pnpx (Recommended) | ||
|
|
||
| The easiest way to use the Trello MCP server is with `pnpx`, which doesn't require a global install: | ||
| The easiest way to use the Trello MCP server is with `pnpx`, which doesn't require a global install. Add the `mcpServers.trello` entry to your [Claude Desktop config file](https://modelcontextprotocol.io/quickstart/user#installing-the-filesystem-server): |
There was a problem hiding this comment.
The link text 'installing-the-filesystem-server' doesn't match the context of installing the Trello server. This appears to be a copy-paste error from filesystem server documentation.
| The easiest way to use the Trello MCP server is with `pnpx`, which doesn't require a global install. Add the `mcpServers.trello` entry to your [Claude Desktop config file](https://modelcontextprotocol.io/quickstart/user#installing-the-filesystem-server): | |
| The easiest way to use the Trello MCP server is with `pnpx`, which doesn't require a global install. Add the `mcpServers.trello` entry to your [Claude Desktop config file](https://modelcontextprotocol.io/quickstart/user): |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
It's not an error, it's just that that's the closest anchor point on the page. The relevant text is a few paragraphs down. At the time of writing, it reads:
Access Developer Settings
In the Settings window, navigate to the “Developer” tab in the left sidebar. This section contains options for configuring MCP servers and other developer features.
Click the “Edit Config” button to open the configuration file:
Developer settings showing Edit Config button
This action creates a new configuration file if one doesn’t exist, or opens your existing configuration. The file is located at:
macOS:
~/Library/Application Support/Claude/claude_desktop_config.jsonWindows:
%APPDATA%\Claude\claude_desktop_config.json
It would be nice to have that in this README, but it seems like something that could go out of date quickly.
| "command": "docker", | ||
| "args": [ | ||
| "run", "-i", "--rm", | ||
| "--volume=npx-cache-20:/root/.npm", |
There was a problem hiding this comment.
[nitpick] The volume name 'npx-cache-20' includes a hardcoded version number '20' that should match the Node.js version used in the container. Consider using a more descriptive name or documenting why this specific version is included.
Copilot uses AI. Check for mistakes.
| "args": [ | ||
| "run", "-i", "--rm", | ||
| "--volume=npx-cache-20:/root/.npm", | ||
| "--volume=node-modules-cache-20:/root/.cache", |
There was a problem hiding this comment.
[nitpick] Similar to the npm cache volume, 'node-modules-cache-20' includes a hardcoded version number that should be consistent with the Node.js version. Consider adding a comment explaining the version alignment or using a more generic naming pattern.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Code Review
This pull request adds valuable documentation for running the Trello MCP server within a Docker container without needing a local git checkout. This provides users with a more secure and isolated execution environment. The implementation is sound, using a standard Node.js image and named volumes for caching. My review includes one suggestion to improve the clarity of the Docker configuration to prevent potential user errors related to cache management when updating Node.js versions.
| "--volume=npx-cache-20:/root/.npm", | ||
| "--volume=node-modules-cache-20:/root/.cache", |
There was a problem hiding this comment.
Using version-specific names for the Docker volumes (e.g., ...-20) is a good practice to align with the node:20-alpine image. However, this dependency isn't immediately obvious. A user might update the Node.js image version later without changing the volume names, which could lead to hard-to-debug cache conflicts. Please consider adding a brief note to the documentation explaining that these volume names should be updated in tandem with the Node.js image version.
1 participant
This PR adds documentation for running mcp-server-trello in Docker, without first checking it out.
I prefer to run it this way because I feel it's more secure.