build: execute perf test when updating release (scolladon#848)

deloitte-engineering · Apr 24, 2024 · 8a44c24 · 8a44c24
1 parent 8d5c927
commit 8a44c24
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/on-main-push.yml b/.github/workflows/on-main-push.yml
@@ -19,6 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     outputs:
       release_created: ${{ steps.release.outputs.release_created }}
+      prs_created: ${{ steps.release.outputs.prs_created }}
       version: ${{ steps.release.outputs.version }}
     steps:
       - uses: google-github-actions/release-please-action@v4
@@ -30,7 +31,7 @@ jobs:
   release:
     needs: [prepare-release]
     runs-on: ubuntu-latest
-    if: needs.prepare-release.outputs.release_created == 'true'
+    if: ${{ needs.prepare-release.outputs.release_created == 'true' }}
     steps:
       - name: Checkout sources
         uses: actions/checkout@v4
@@ -59,7 +60,7 @@ jobs:
   perf:
     needs: [prepare-release]
     runs-on: ubuntu-latest
-    if: needs.prepare-release.outputs.release_created != 'true'
+    if: ${{ needs.prepare-release.outputs.release_created != 'true' && needs.prepare-release.outputs.prs_created == 'true' }}
     steps:
       - name: Checkout sources
         uses: actions/checkout@v4

diff --git a/.github/workflows/on-merged-pull-request.yml b/.github/workflows/on-merged-pull-request.yml
@@ -8,7 +8,7 @@ on:
 
 jobs:
   clean-npm-dev-version:
-    if: github.event.pull_request.merged == true
+    if: ${{ github.event.pull_request.merged == 'true' }}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
@@ -42,9 +42,9 @@ jobs:
         env:
           NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
 
-      - name: Delete package dev channel PR comment 
+      - name: Delete package dev channel PR comment
         uses: thollander/actions-comment-pull-request@v2
         with:
-          message: 
+          message: ""
           comment_tag: dev-publish
           mode: delete
diff --git a/.github/workflows/on-pull-request.yml b/.github/workflows/on-pull-request.yml
@@ -103,7 +103,7 @@ jobs:
   publish-dev:
     needs: [build]
     runs-on: ubuntu-latest
-    if: github.event.pull_request.merged != 'true' && github.actor != 'dependabot[bot]'
+    if: ${{ github.event.pull_request.merged != 'true' && github.actor != 'dependabot[bot]' }}
     outputs:
       devChannel: ${{ steps.define_dev_channel.outputs.DEV_CHANNEL }}
     steps: