Update intel benchmark code to work with new architecture #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into pub/new_architecture
|
Can one of the admins verify this patch? |
|
If PR is raising in staging, same changes will need to raise in pub/new_architecture also |
abhishek-sa1
reviewed
Apr 2, 2025
| @@ -13,6 +13,10 @@ | |||
| # limitations under the License. | |||
| --- | |||
|
|
|||
| - name: Include input project directory | |||
There was a problem hiding this comment.
update copyright in all files
There was a problem hiding this comment.
I updated the copyrights.
jagadeeshnv
reviewed
Apr 2, 2025
Cypher-Miller
changed the title
jagadeeshnv
reviewed
Apr 15, 2025
jagadeeshnv
reviewed
Apr 15, 2025
| @@ -89,8 +89,8 @@ | |||
| ansible.builtin.set_fact: | |||
| openmpi_compile_cmd: "../configure --prefix={{ omnia_share_path }}/{{ benchmarks_dir_openmpi }} | |||
| --enable-mpi1-compatibility --enable-prte-prefix-by-default | |||
| {{ '--with-slurm=yes' if slurm_support else '--with-slurm=no' }}{{ ' --with-ucx=' + ucx_dir_data.stat.path + ' ' if ucx_installed else ' ' }}CC=clang | |||
| CXX=clang++ 2>&1 | tee config.out" | |||
There was a problem hiding this comment.
If this is the case, clang packages being installed are of no use, can remove that part also
There was a problem hiding this comment.
I removed the clang package install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Solution
Updated and tested:
ansible-playbook local_repo.yml (To close download intel and amd packages to the pulp container)
ansible-playbook scheduler.yml -i inv -v (To install slurm and install openmpi and ucx packages)
ansible-playbook intel_benchmark.yml -i inv -v (To install downloaded intel packages into cluster nodes)
@jagadeeshnv @snarthan