Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preflight scans #149

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix preflight scans #149

merged 1 commit into from
Apr 17, 2024

Conversation

panigs7
Copy link
Contributor

@panigs7 panigs7 commented Apr 15, 2024

Description

Fix Preflight scans. Topology image is missing the licenses used by the metrics in its image.
image
This is blocking publishing of topology image in RedHat catalog.

Added the changes to include licenses in the topology image.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Preflight scans passed:
image

@csmbot
Copy link
Collaborator

csmbot commented Apr 15, 2024

Can one of the admins verify this patch?

Copy link
Collaborator

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide more details on why these changes are required in the description of the pull request.

@panigs7 panigs7 requested a review from gallacher April 15, 2024 15:12
@panigs7
Copy link
Contributor Author

panigs7 commented Apr 15, 2024

Please provide more details on why these changes are required in the description of the pull request.

Done

@prablr79 prablr79 merged commit 9c7e405 into main Apr 17, 2024
6 of 7 checks passed
@tdawe tdawe deleted the fix-preflight-scans branch October 17, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants