Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI PowerMax: update nguid match to WWN #52

Merged
merged 2 commits into from
Jun 21, 2024
Merged

CSI PowerMax: update nguid match to WWN #52

merged 2 commits into from
Jun 21, 2024

Conversation

delldubey
Copy link
Contributor

@delldubey delldubey commented Jun 14, 2024 •
edited
Loading

Description

  • update nguid match to WWN
  • Add additional debug logs for NVMe.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1308

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Cluster Test
  • Unit Test
  • image

@delldubey delldubey force-pushed the feature/pmaxNvme branch 2 times, most recently from 398ad9f to e2d6535 Compare June 14, 2024 17:16
@delldubey
updated nguid match with wwn for pmax
3129b9d 
Signed-off-by: Utkarsh Dubey <Utkarsh.Dubey@dell.com>
@atye
Copy link

atye commented Jun 14, 2024

Are there new unit tests that can be added to cover the changes?

@alikdell
Copy link
Contributor

  • I have maintained at least 90% code coverage

How are you achieving this without unit test code?

@delldubey delldubey force-pushed the feature/pmaxNvme branch 2 times, most recently from bac24fd to 25778f9 Compare June 20, 2024 20:40
@harishp8889
Copy link
Contributor

Can you please attach the current coverage report. I don't see it running in the pipeline

@delldubey
Copy link
Contributor Author

Can you please attach the current coverage report. I don't see it running in the pipeline

Done

@delldubey delldubey merged commit 12722c2 into main Jun 21, 2024
4 checks passed
@anandrajak1 anandrajak1 deleted the feature/pmaxNvme branch October 17, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikdell alikdell alikdell approved these changes

@atye atye atye approved these changes

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delldubey @atye @alikdell @harishp8889