Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Apex Connectivity Client #708

Closed
wants to merge 11 commits into from
Closed

Removing Apex Connectivity Client #708

wants to merge 11 commits into from

Conversation

anathoodell
Copy link
Contributor

@anathoodell anathoodell commented Sep 26, 2024 •
edited
Loading

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1484

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@anathoodell anathoodell linked an issue Sep 27, 2024 that may be closed by this pull request
[FEATURE]: Remove ACC Support dell/csm#1484
Closed
francis-nijay
francis-nijay reviewed Sep 30, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
francis-nijay
francis-nijay reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@francis-nijay francis-nijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some yaml lint errors

ChristianAtDell
ChristianAtDell reviewed Oct 4, 2024
View reviewed changes
pkg/utils/utils.go Outdated
return nil
}

// 2nd parameter is an ApexCC cr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this entire comment block be removed? It is related only to ACC, which we are trying to remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, removed.

ChristianAtDell
ChristianAtDell reviewed Oct 4, 2024
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
ChristianAtDell
ChristianAtDell reviewed Oct 4, 2024
View reviewed changes
tests/e2e/steps/steps_def.go
@@ -91,6 +91,7 @@ var correctlyAuthInjected = func(cr csmv1.ContainerStorageModule, annotations ma
}

// GetTestResources -- parse values file
// TBD: remove apex param from here and caller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a blocker that is preventing us from removing this param now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really. just have to make the change. i will do so.

@anathoodell
Copy link
Contributor Author

The commits in this PR are merged into pub/krv-28556 branch, and a PR for this is available #721. As a result, this PR is being closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianAtDell ChristianAtDell ChristianAtDell left review comments

@francis-nijay francis-nijay francis-nijay left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 will be requested when the pull request is marked ready for review abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell will be requested when the pull request is marked ready for review mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell will be requested when the pull request is marked ready for review alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth will be requested when the pull request is marked ready for review bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain will be requested when the pull request is marked ready for review chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof will be requested when the pull request is marked ready for review coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari will be requested when the pull request is marked ready for review Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher will be requested when the pull request is marked ready for review gallacher is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran will be requested when the pull request is marked ready for review gilltaran is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 will be requested when the pull request is marked ready for review harishp8889 is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL will be requested when the pull request is marked ready for review HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros will be requested when the pull request is marked ready for review JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna will be requested when the pull request is marked ready for review jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 will be requested when the pull request is marked ready for review karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa will be requested when the pull request is marked ready for review kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 will be requested when the pull request is marked ready for review bandak2 is a code owner

@meggm meggm Awaiting requested review from meggm meggm will be requested when the pull request is marked ready for review meggm is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva will be requested when the pull request is marked ready for review mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell will be requested when the pull request is marked ready for review mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 will be requested when the pull request is marked ready for review nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell will be requested when the pull request is marked ready for review Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri will be requested when the pull request is marked ready for review rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani will be requested when the pull request is marked ready for review rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra will be requested when the pull request is marked ready for review shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 will be requested when the pull request is marked ready for review panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe will be requested when the pull request is marked ready for review tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro will be requested when the pull request is marked ready for review shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye will be requested when the pull request is marked ready for review atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama will be requested when the pull request is marked ready for review sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell will be requested when the pull request is marked ready for review shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Remove ACC Support
4 participants
@anathoodell @francis-nijay @ChristianAtDell @bpjain2004