Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GO version #109

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Update GO version #109

merged 1 commit into from
Oct 12, 2022

Conversation

karthikk92
Copy link
Collaborator

Description

Update GO version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#491

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

https://osj-sio-03-prd.cec.lab.emc.com/job/CSM-Operator/job/csm-operator-build/206/

rensyct
rensyct suggested changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@rensyct rensyct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there are changes in all the manifest files.. Please rebase your branch and revert the changes made in all manifest files

@karthikk92
Copy link
Collaborator Author

Why there are changes in all the manifest files.. Please rebase your branch and revert the changes made in all manifest files

@rensyct rebased and now all the changes taken care after rebase.

jooseppi-luna
jooseppi-luna previously approved these changes Oct 11, 2022
View reviewed changes
@karthikk92 karthikk92 force-pushed the updated_go_version branch 2 times, most recently from d0d25b7 to 33fd27b Compare October 12, 2022 06:02
panigs7
panigs7 previously approved these changes Oct 12, 2022
View reviewed changes
rensyct
rensyct previously approved these changes Oct 12, 2022
View reviewed changes
@rensyct
Copy link
Contributor

rensyct commented Oct 12, 2022

@karthikk92 , please sign your commit

@karthikk92 karthikk92 dismissed stale reviews from rensyct and panigs7 via aaaefed October 12, 2022 07:00
@karthikk92
Copy link
Collaborator Author

@karthikk92 , please sign your commit

taken care

@rensyct rensyct merged commit c3efd22 into main Oct 12, 2022
jooseppi-luna pushed a commit that referenced this pull request Oct 13, 2022
@karthikk92 @jooseppi-luna
Updated the go version to 1.19 from 1.18 (#109)
9c31f93
jooseppi-luna added a commit that referenced this pull request Oct 14, 2022
@jooseppi-luna @rensyct
@gallacher @karthikk92
E2e ginkgo 1 16 5 (#104)
3c7f71d 
* e2e tests working and improved

* Update README.md

* add modules field in test spec

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* fixed gofmt added cleanup

* Update README.md

* Update allowedlist.yaml

* Update allowedlist.yaml

* Update values.yaml

* e2e tests working and improved

* add modules field in test spec

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* fixed gofmt added cleanup

* Update README.md

* Update allowedlist.yaml

* Update allowedlist.yaml

* Bump up version to 1.0.0 (#108)

* Removed links from TOC (#107)

* Updated the go version to 1.19 from 1.18 (#109)

* updated from v1alpha1 to v1 (#110)

* Update values.yaml

* observability

Co-authored-by: rensyct <80810999+rensyct@users.noreply.github.com>
Co-authored-by: gallacher <35462391+gallacher@users.noreply.github.com>
Co-authored-by: karthikk92 <92289639+karthikk92@users.noreply.github.com>
@rensyct rensyct deleted the updated_go_version branch January 11, 2023 11:52
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Updated the go version to 1.19 from 1.18 (#109)
333b8ac
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell @rensyct
@gallacher @karthikk92
E2e ginkgo 1 16 5 (#104)
7c9f37a 
* e2e tests working and improved

* Update README.md

* add modules field in test spec

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* fixed gofmt added cleanup

* Update README.md

* Update allowedlist.yaml

* Update allowedlist.yaml

* Update values.yaml

* e2e tests working and improved

* add modules field in test spec

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* fixed gofmt added cleanup

* Update README.md

* Update allowedlist.yaml

* Update allowedlist.yaml

* Bump up version to 1.0.0 (#108)

* Removed links from TOC (#107)

* Updated the go version to 1.19 from 1.18 (#109)

* updated from v1alpha1 to v1 (#110)

* Update values.yaml

* observability

Co-authored-by: rensyct <80810999+rensyct@users.noreply.github.com>
Co-authored-by: gallacher <35462391+gallacher@users.noreply.github.com>
Co-authored-by: karthikk92 <92289639+karthikk92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panigs7 panigs7 panigs7 approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@rensyct rensyct rensyct approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth left review comments

@jooseppi-luna jooseppi-luna jooseppi-luna left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@nb950 nb950 Awaiting requested review from nb950

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@karthikk92 @rensyct @jooseppi-luna @rajendraindukuri @panigs7 @bharathsreekanth