Skip to content

Update golangci-lint action #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 17, 2025
Merged

Update golangci-lint action #128

merged 6 commits into from
Feb 17, 2025

Conversation

shaynafinocchiaro
Copy link
Contributor

@shaynafinocchiaro shaynafinocchiaro commented Feb 17, 2025 •
edited by anandrajak1
Loading

Description

golangci-lint action fails on custom linters configuration because JSONschema verification was changed to true by default in the linter action. This PR updates the config file to remove unused parameters to pass the verify check
Reference: golangci/golangci-lint-action#1171

Configuration file docs: https://golangci-lint.run/usage/configuration/#config-file

Issues

List the issues impacted by this PR:

Issue ID
dell/csm#1707

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@shaynafinocchiaro shaynafinocchiaro merged commit df59884 into main Feb 17, 2025
2 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the fix-golangci-lint branch February 17, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AronAtDell AronAtDell AronAtDell approved these changes

@ChristianAtDell ChristianAtDell ChristianAtDell approved these changes

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaynafinocchiaro @AronAtDell @ChristianAtDell