Skip to content
This repository was archived by the owner on Sep 21, 2025. It is now read-only.

Conversation

@VSpike
Copy link
Contributor

@VSpike VSpike commented Apr 24, 2019

Setting DATABASE_STATEMENT_TIMEOUT variable to -1 will now prevent enforcing a statement_timeout in the DB config. The previous behaviour conflicts with PGBouncer and cannot be disabled.

@VSpike VSpike force-pushed the SRE-xxx/disable_flag_statement_timeout branch 2 times, most recently from acc25b0 to 616e695 Compare April 25, 2019 10:42
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files          93       93           
  Lines        2751     2751           
=======================================
  Hits         2568     2568           
  Misses        183      183

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5bddfc...3eba9c3. Read the comment docs.

@VSpike VSpike force-pushed the SRE-xxx/disable_flag_statement_timeout branch from 616e695 to a8f2850 Compare April 25, 2019 11:05
@VSpike VSpike changed the title SRE-xxx: Add env var to disable statement_timeout SRE-1005: Add env var to disable statement_timeout May 22, 2019
@VSpike VSpike force-pushed the SRE-xxx/disable_flag_statement_timeout branch from 3200cbe to 2fa1a94 Compare May 22, 2019 21:49
Setting DATABASE_STATEMENT_TIMEOUT to -1 will now
prevent the app from attempting to set a timeout
on DB sessions.
@VSpike VSpike force-pushed the SRE-xxx/disable_flag_statement_timeout branch from 2fa1a94 to d1015f7 Compare May 24, 2019 11:38
@VSpike VSpike self-assigned this May 24, 2019
@VSpike VSpike requested a review from tompave-roo May 24, 2019 16:28
@VSpike VSpike changed the title SRE-1005: Add env var to disable statement_timeout SRE-1005: Add option to disable statement_timeout May 28, 2019
@VSpike VSpike merged commit 8d18f10 into master May 28, 2019
@VSpike VSpike deleted the SRE-xxx/disable_flag_statement_timeout branch May 28, 2019 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants