Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): Add configuration for adding javascript version. #7

Closed
wants to merge 2 commits into from

Conversation

Moumi
Copy link

@Moumi Moumi commented Mar 2, 2016

Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run.

Closes karma-runner#1719

Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run.

Closes karma-runner#1719
@Moumi
Copy link
Author

Moumi commented Mar 2, 2016

Please pull this fix to your own computer and perform grunt test. Make sure that all tests pass. If not, please provide which tests fail and the errors given. Also look if additional comments are needed in the code.

@liuyiran13
Copy link

Get it , I will do the tests soon.

@Moumi Moumi self-assigned this Mar 3, 2016
@wesleyvanderlee
Copy link

My tests are failing due to this error:

TypeError: Cannot read property 'replace' of null

Seems to me that an object is null where it isn't supposed to be. Maybe you need to place an additional check or enforce object initialization.

See here for full test output.

Regards,

Wesley van der Lee

@Moumi
Copy link
Author

Moumi commented Mar 3, 2016

@wesleyvanderlee It seems that the test failures you are getting are not due to my change. Something is probably wrongly setup in your development environment.

@ludai0106
Copy link

Tests are passed with the changes !

@liuyiran13
Copy link

My test also failed and get the error like this:

TypeError: Cannot read property 'replace' of null

@Moumi
Copy link
Author

Moumi commented Mar 4, 2016

Let's look into this when we are together. I might be able to help you fix your environment.

@Moumi
Copy link
Author

Moumi commented Mar 7, 2016

This is still awaiting a proper review. Please review!

@wesleyvanderlee
Copy link

I reconfigured my environment according to this site. Still get the same errors. Because everyone encounters those errors, I don't think it fully relies on the way our environment is set up. We should look together into this..

@Moumi
Copy link
Author

Moumi commented Mar 7, 2016

@wesleyvanderlee @liuyiran13 Why not create a VM with a Linux version on it and test it out?

Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run.

Closes karma-runner#1719
@Moumi
Copy link
Author

Moumi commented Mar 8, 2016

Did not seem to squash the commits for this PR together, therefore I created a new PR #8. Please review that one.

This one is now closed.

@Moumi Moumi closed this Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants