Webworker Analytics #736
Merged
Webworker Analytics #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruler501
force-pushed
the
webworker-analytics
branch
8 times, most recently
from
d41c21f
to
bacf56d
Compare
ruler501
force-pushed
the
webworker-analytics
branch
8 times, most recently
from
5c054b2
to
ed3ea71
Compare
ruler501
force-pushed
the
webworker-analytics
branch
4 times, most recently
from
8ac0bbb
to
5224492
Compare
dekkerglen
requested changes
Jan 14, 2020
| return cardName; | ||
| } else if (section.startsWith('[[')) { | ||
| const cardIndex = parseInt(section.substring(2, section.length - 2), 10); | ||
| const card = cube.cards[cardIndex]; |
There was a problem hiding this comment.
This requires this component to be passed a cube object. Can we revise this such that it either: makes an API call to the server asking for the card object that matches the name, or the autocard to a new route on the server that redirects to the correct image.
Then we can use in a lot of other places too, without having to pass through this object.
There was a problem hiding this comment.
You don't need to change it for this PR, on second thought. I'll create a separate issue for this
Add filters to analysis Add markdown formatting for analytics. Update colorCount analytics.
Handle when there are no draft formats for a cube.
Run Prettier on the analytics changes. Remove the tests for old system. Need to add new tests. Remove obsolete files.
Fix type breakdown when some colors have no cards.
Refactor Chart Visualizations to work with arbitrary chart types. Refactor and add row headers to tables.
Revert package-lock.json changes. Remove unused setutils
ruler501
force-pushed
the
webworker-analytics
branch
from
5224492
to
cc194eb
Compare
ruler501
force-pushed
the
webworker-analytics
branch
from
cc194eb
to
1184bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put together a rough proof of concept of one way to do user customizable analytics for #19. You can test it out at https://cubecobra.ruler501.com/cube/analysis/packwars. It supports tables and bar charts currently.
The UI could use a decent amount of work. I'm relatively poor at designing and writing UI so have been focused mostly on getting the functionality working.
The overarching idea is to have analytics be run on the client side over the set of cards in the cube through WebWorkers which provide isolation from the page environment. These scripts would receive messages with the cards and respond with descriptions of the visualization they want for their analytic. I planned to allow responses to render tables, line graphs, bar graphs, pie charts, word clouds and card image with associated text grids(like the token analytic now).
This also introduces a markdown lke language that supports rendering percentages, mana symbols, card images, and card links with autocard.
Further work intended is to add the other visualization supports mentioned, port over all existing analytic functions, add tests, and make the script requirements and how to write more discoverable.
Custom analytics has been dropped from scope for now due to security concerns.
Changes and Features:
Potential Future Work: