use a frozen copy of Rails.root in AppNotifications and LogInterceptor #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was playing with https://github.com/schneems/derailed_benchmarks while debugging a memory leak in an application and i saw that meta_request was allocating a lot of memory:
the specific culprits were:
both of which involve converting
Rails.root
from aPathname
into aString
.this change adds a
MetaRequest.rails_root
method which caches a frozen copy ofRails.root.to_s
and drops the total memory allocation of a rails boot to 40% of the previous value: