Disable pry-byebug when invoked by pry-rescue #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See ConradIrwin/pry-rescue#124 --- pry-byebug doesn't play nicely with pry-rescue. Detect if we're in a rescued exception, and if so, use pry without byebug.
|
Please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ConradIrwin/pry-rescue#124 --- pry-byebug doesn't play nicely with pry-rescue. pry-rescue works by capturing the call stack, and later invoking pry using that call stack (not the current one) as the target.
I think the correct fix would be to allow ByeBug::PryProcessor.start (called from here) to receive a
targetand use that to initialize the context of byebug. But there doesn't seem to be an easy way to modify byebug to operate within an arbitrary call stack.So as a workaround for now, just disable the use of byebug when pry was entered via pry-rescue. We can detect this by the presence of the
save_captured_exceptionhook.