-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
This could be game changing. We've been looking for a websocket-compatible HTTP server that works with django for a while. This could mean that we could potentially support |
Should be able to, tho the alternative could have always been to have a logger endpoint (public) we could pass on the connection to the end user which could allow for it instead of piping via the API |
While benchmarking, it might be interesting to also try out https://github.com/MagicStack/uvloop via the implementation in aio-libs/aiohttp#878. See http://magic.io/blog/uvloop-blazing-fast-python-networking/ for some existing benchmarks. |
6a01662
to
a55676a
Compare
Current coverage is 86.57%@@ master #794 diff @@
==========================================
Files 30 30
Lines 2712 2711 -1
Methods 0 0
Messages 0 0
Branches 441 441
==========================================
- Hits 2350 2347 -3
- Misses 240 242 +2
Partials 122 122
|
53de89e
to
8467e1f
Compare
13b60ef
to
16b326a
Compare
16b326a
to
a3b9a6e
Compare
I did spend some time using the |
This seems promising, especially when paired with the potential of So I'm closing this, but it would be smart for someone to revisit this territory in the future after #833 or #835 are (probably) merged. |
docs(monitoring): Update docs to reflect monitor chart changes
Summary of Changes
Replaces the default
sync
gunicorn worker class withgaiohttp
. This async worker class is based onaiohttp
for Python 3. It may offer better responsiveness and lower CPU load.My preliminary testing shows it holds up well and uses less CPU, but I'll produce more specific benchmark results to justify this soon.
TODO:
Testing Instructions
There are no specific testing instructions, since this should be an invisible backend change. However, monitoring for response times and CPU load over a long period of time would assure this does not introduce new problems.
Pull Request Hygiene TODOs
Please make sure the below checklist is complete.
🌸 Thank you! 🌸