Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

feat(api): allow app names up to 63 characters in length #1198

Merged
merged 1 commit into from
Mar 31, 2017
Merged

feat(api): allow app names up to 63 characters in length #1198

merged 1 commit into from
Mar 31, 2017

Conversation

bacongobbler
Copy link
Member

@bacongobbler bacongobbler added this to the v2.11 milestone Jan 11, 2017
@bacongobbler bacongobbler self-assigned this Jan 11, 2017
@deis-bot
Copy link

@helgi, @kmala and @mboersma are potential reviewers of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

@bacongobbler bacongobbler mentioned this pull request Jan 11, 2017
Merged
@bacongobbler bacongobbler mentioned this pull request Jan 17, 2017
Closed
@tmc
Copy link

tmc commented Jan 24, 2017

@bacongobbler ci failure is from #logging.disable(logging.ERROR) line

@bacongobbler
Copy link
Member Author

bacongobbler commented Jan 24, 2017 •
edited
Loading

@tmc that line is to enable debug logging to see what's going on in CI. I'm focused on other work right now but please feel free to take this up if you have cycles. I'll get back to this eventually.

@bacongobbler bacongobbler modified the milestones: v2.12, v2.11 Jan 26, 2017
@bacongobbler
Copy link
Member Author

personal note: needs a rebase on top of #1199 as well

@mboersma mboersma modified the milestones: v2.13, v2.12 Feb 27, 2017
@bacongobbler bacongobbler force-pushed the 212-app-name-length branch 8 times, most recently from ac42e46 to 0dd48e2 Compare March 24, 2017 18:44
@bacongobbler
Copy link
Member Author

I vastly simplified this PR to just bump the maximum app name length to 63 characters. I don't imagine we have anyone running Workflow v2.13 on a k8s 1.3 cluster any more... Everyone is running at least 1.4.

@bacongobbler bacongobbler changed the title feat(api): allow app names larger than 24 characters in length feat(api): allow app names up to 63 characters in length Mar 24, 2017
@bacongobbler
Copy link
Member Author

Jenkins, test this please.

@codecov-io
Copy link

codecov-io commented Mar 24, 2017 •
edited
Loading

Codecov Report

Merging #1198 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
+ Coverage   86.63%   86.65%   +0.02%     
==========================================
  Files          45       45              
  Lines        3928     3928              
  Branches      681      681              
==========================================
+ Hits         3403     3404       +1     
+ Misses        356      355       -1     
  Partials      169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17120b7...a95bba7. Read the comment docs.

@vdice vdice added the LGTM1 label Mar 27, 2017
@bacongobbler bacongobbler merged commit 0e117b1 into deis:master Mar 31, 2017
@bacongobbler bacongobbler deleted the 212-app-name-length branch March 31, 2017 16:58
@bacongobbler bacongobbler mentioned this pull request Apr 4, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bacongobbler bacongobbler

Labels
enhancement LGTM1 LGTM2
Projects
None yet
Milestone
v2.13
Development

Successfully merging this pull request may close these issues.

App name length limited to 24 characters
6 participants
@bacongobbler @deis-bot @tmc @codecov-io @mboersma @vdice