This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(api): account for NoneType when resource is gone #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@helgi, @kmala and @zinuzoid are potential reviewers of this pull request based on my analysis of |
bacongobbler
force-pushed
the
fix-k8s-1.5-response
branch
2 times, most recently
from
3630fe7 to
338d618
Compare
In versions prior to Kubernetes v1.5, an empty list was returned when a resource didn't exist. in v1.5 it now returns a NoneType, so we need to account for that change and convert it back to an empty list.
bacongobbler
force-pushed
the
fix-k8s-1.5-response
branch
from
338d618 to
f7e6b27
Compare
Current coverage is 87.49% (diff: 58.82%)@@ master #1178 diff @@
==========================================
Files 43 43
Lines 3749 3774 +25
Methods 0 0
Messages 0 0
Branches 649 661 +12
==========================================
+ Hits 3291 3302 +11
- Misses 300 308 +8
- Partials 158 164 +6
|
|
manually tested and confirmed that this works on k8s 1.5 and k8s 1.4. |
mboersma
pushed a commit
that referenced
this pull request
Dec 14, 2016
In versions prior to Kubernetes v1.5, an empty list was returned when a resource didn't exist. in v1.5 it now returns a NoneType, so we need to account for that change and convert it back to an empty list.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions prior to Kubernetes v1.5, an empty list was returned when a resource didn't exist. in
v1.5 it now returns a NoneType, so we need to account for that change and convert it back to an
empty list.
fixes #1175