Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week 4 Submission #65

Closed
wants to merge 9 commits into from
Closed

Week 4 Submission #65

wants to merge 9 commits into from

Conversation

frasermarlow
Copy link

(.venv) frasermarlow@Elementl corise-dagster % asermarlow@Elementl corise-dagster % make week_4_tests
================================================================================================================ test session starts ================================================================================================================
platform darwin -- Python 3.10.6, pytest-7.1.3, pluggy-0.13.1 -- /Users/frasermarlow/corise-dagster/.venv/bin/python3.10
cachedir: .pytest_cache
rootdir: /Users/frasermarlow/corise-dagster, configfile: pytest.ini
plugins: anyio-3.6.1
collected 11 items

week_4/tests/test_answer.py::test_stock PASSED [ 9%]
week_4/tests/test_answer.py::test_stock_class_method PASSED [ 18%]
week_4/tests/test_answer.py::test_aggregation PASSED [ 27%]
week_4/tests/test_answer.py::test_get_s3_data PASSED [ 36%]
week_4/tests/test_answer.py::test_process_data PASSED [ 45%]
week_4/tests/test_answer.py::test_put_redis_data PASSED [ 54%]
week_4/tests/test_answer.py::test_get_s3_data_docker PASSED [ 63%]
week_4/tests/test_answer.py::test_process_data_docker PASSED [ 72%]
week_4/tests/test_answer.py::test_put_redis_data_docker PASSED [ 81%]
week_4/tests/test_resources.py::test_s3_resource PASSED [ 90%]
week_4/tests/test_resources.py::test_redis_resource PASSED [100%]

================================================================================================================= warnings summary ==================================================================================================================
.venv/lib/python3.10/site-packages/redis/connection.py:77
/Users/frasermarlow/corise-dagster/.venv/lib/python3.10/site-packages/redis/connection.py:77: UserWarning: redis-py works best with hiredis. Please consider installing
warnings.warn(msg)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================================================================================================== 11 passed, 1 warning in 0.77s ===========================================================================================================
(.venv) frasermarlow@Elementl corise-dagster % clear

Copy link

@rsanjabi rsanjabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! Despite green tests, I was getting an error when using Dagit unless I removed the challenge problem from the repo.py file. Something to consider if you ran into that problem.

@frasermarlow frasermarlow closed this by deleting the head repository Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants