Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week3 #54

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Week3 #54

wants to merge 7 commits into from

Conversation

svpernova09
Copy link

No description provided.

Copy link

@TwoMinds TwoMinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. The code looks good to me. The only things I think you can improve on is using a list comprehension to define your partitions and creating a function to return your run config instead of hardcoding it. Overall, great job.

def docker_config():
pass
@static_partitioned_config(partition_keys=["1", "2", "3", "4", "5", "6", "7", "8", "9", "10"])
def docker_config(partition_key: int):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small inconsistency here (partition_key: int), as partition_keys in the line above are outlined as strings.

Copy link

@amaralvieira amaralvieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍 And now I learned that you can have yield and return statements in the same function 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants