Normalize args when deriving the redis lock key.#6
Open
dylanahsmith wants to merge 1 commit intodefunkt:masterfrom
Open
Normalize args when deriving the redis lock key.#6dylanahsmith wants to merge 1 commit intodefunkt:masterfrom
dylanahsmith wants to merge 1 commit intodefunkt:masterfrom
Conversation
Otherwise the before_enqueue_lock will create a different redis key than around_perform_lock deletes.
|
+1, i came across this today |
|
+1, locks with symbolized arguments are never deleted from Redis. |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, the before_enqueue_lock will create a different redis key than around_perform_lock deletes.
This can be tested by using a symbol in the arguments, which gets encoded as a string. A regression test was added to unsure this issue is handled.