Allow jobs to be queuable once the existing job starts performing#16
Open
lazyatom wants to merge 1 commit intodefunkt:masterfrom
Open
Allow jobs to be queuable once the existing job starts performing#16lazyatom wants to merge 1 commit intodefunkt:masterfrom
lazyatom wants to merge 1 commit intodefunkt:masterfrom
Conversation
This is useful when you know that the currently running job might not be taking into account the most recent updates to some of the data it is operating on, which can occur when the jobs take some time to run. For example: 1. update model 2. queue job to index in ElasticSearch 3. job starts performing 4. another update happens to the model 5. try to queue job to update index With the default queue locking mechanism, step 5 will only succeed in enqueuing a new job if the job that started in step 3 has already completed. However, if that job hasn't finished, but has loaded the model with only the changes from step 1, then the changes introduced in step 4 won't get indexed. With `unlock_while_performing` set to true, there can always be a single pending job in the queue, even when there's also a job running, and so we can be confident that any un-indexed changes to the model will get indexed once the final job finishes running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful when you know that the currently running job might not be
taking into account the most recent updates to some of the data it is
operating on, which can occur when the jobs take some time to run.
For example:
With the default queue locking mechanism, step 5 will only succeed in
enqueuing a new job if the job that started in step 3 has already
completed. However, if that job hasn't finished, but has loaded the
model with only the changes from step 1, then the changes introduced in
step 4 won't get indexed.
With
unlock_while_performingset to true, there can always be a singlepending job in the queue, even when there's also a job running, and so
we can be confident that any un-indexed changes to the model will get
indexed once the final job finishes running.