Abort pending XHR in popstate handler #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/unit/pjax.js
Outdated
Collaborator
There was a problem hiding this comment.
Why do we want to load hello.html in this test? Won't just timeout.html suffice?
Contributor
Author
There was a problem hiding this comment.
I think this is a remnant from when I had the pushState delay and this change in the same branch. Because browsers go to the n-1th page when you click back natively, you need to push something onto your history stack first if you're emulating that behaviour.
Collaborator
There was a problem hiding this comment.
Well, if this is not necessary for this test, I'd like to see it removed.
Contributor
|
@mislav any progress on this? |
Collaborator
|
This is an important thing to fix. Sorry for sitting on this for too long. I will review this for the next release. |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where, if the user clicks back while a PJAX request is loading, the originally requested page is displayed anyway once the XHR response arrives.