Skip to content

Added .gitignore to ignore 'bower_components' and Gemfile to bundle test... #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added .gitignore to ignore 'bower_components' and Gemfile to bundle test... #391

wants to merge 2 commits into from

Conversation

@kim3er
Copy link
Contributor

@kim3er kim3er commented May 11, 2014

... gem requirements

@mislav
Copy link
Collaborator

mislav commented May 11, 2014

  1. I don't think ignoring bower_compoents is necessary since bower install isn't required for pjax development.
  2. If you're going to add a Gemfile, then the "Contributing" section of the README needs to be updated with instructions to use bundle install and bundle exec ruby ... instead of just ruby ...

@kim3er
Copy link
Contributor Author

kim3er commented May 11, 2014

Bower
Fair enough. I hadn't noticed that their was a copy of jQuery in the test suite and had assumed Bower was was required there.

Gemfile
I'll update the README accordingly.

@kim3er
Copy link
Contributor Author

kim3er commented May 11, 2014

@mislav Both changes have been made.

@mislav mislav closed this in e43cdf3 May 12, 2014
@kim3er kim3er deleted the feature/cleanup-repo branch May 12, 2014 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kim3er @mislav