Ignore events with prevented defaults #379
Conversation
test/unit/fn_pjax.js
Outdated
There was a problem hiding this comment.
The test should be unpaused here after a timeout, to allow potential async stuff to happen (even though we don't expect it).
So, instead of a start() at the end of the test, you shoud add something like setTimeout(start, 10) here in the click handler. This way we can be sure that the click actually happened.
There was a problem hiding this comment.
OK, @marcandre, this will be good to go as soon as you improve this test in the manner that I described. Let me know if you won't have a chance to do it. Thanks!
|
Looks alright. @josh do you think this is in order? |
|
👍 |
|
Sure, test improved. |
test/unit/fn_pjax.js
Outdated
There was a problem hiding this comment.
Close, but not there yet. What I now want you to do is move this entire setTimeout block to inside of the click handler for the a[href='/dinosaurs.html'] element. This is so we can be sure that the click handler has actually ran.
Also, you can reduce the timeout from 100ms to something smaller like 10ms.
Ignore events with prevented defaults
|
Thanks! |
3 participants
If a click event has a prevented default (say because some other JS has already handled the event doing something else) then
pjaxshould ignore the event.It seems obvious to me, but if further justification is needed, not ignoring the event behaves differently than the fallback behavior (non pushState browsers or if calling
$.pjax.disable()).