Using CA certificates in standalone script. Fixes defunkt/gist#23 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order is very important in building the standalone script, so hopefully these verbose messages will make it clearer when the build gets out-of-order, e.g. because of aggressive globbing in the build script.
| @@ -120,7 +120,19 @@ module Gist | |||
|
|
|||
| http.use_ssl = true | |||
| http.verify_mode = OpenSSL::SSL::VERIFY_PEER | |||
| http.ca_file = File.join(File.dirname(__FILE__), "cacert.pem") | |||
There was a problem hiding this comment.
http.ca_file = File.join(File.dirname(__FILE__), "gist", "cacert.pem") fixes the issue for me. Just a path issue, cacert.pem is located in lib/gist/ not lib/ where this file is looking for it.
|
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rduplain/gist@1e29722b84635b8fa680dca4fd7e32a976402138 uses bundled CA certificates to fix #23 where the gist script was unable to Gist.write using HTTPS.
It's not clear to me how this project is used outside the standalone script, so I couldn't verify that http.ca_file is being set correctly when not using the standalone gist script.
Other commits address an issue where
rake standalonewas building the gist script in the wrong order on my Debian-based GNU/Linux machine.-Ron