Remove anonymous support due to deprecation. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes defunkt#275 This change is needed due to the deprecation warning/removal made by Github on the gist tool. See https://blog.github.com/2018-02-18-deprecation-notice-removing-anonymous-gist-creation/ for more info.
|
pinging @rking and @ConradIrwin for review 😀 |
ConradIrwin
reviewed
May 21, 2018
lib/gist.rb
Outdated
| @@ -127,7 +127,8 @@ def multi_gist(files, options={}) | |||
|
|
|||
| existing_gist = options[:update].to_s.split("/").last | |||
| if options[:anonymous] | |||
| access_token = nil | |||
| raise 'Anonymous gist support has been removed by Github. ' \ | |||
| 'See: https://blog.github.com/2018-02-18-deprecation-notice-removing-anonymous-gist-creation/' | |||
There was a problem hiding this comment.
@estebanz01 Thanks for this — can we make this error explain to the user what to do about it?
raise 'Please log in with `gist --login`. (Github now requires credentials to gist https://bit.ly/2GBBxKw)'
|
@estebanz01 Thanks for your help! I'd like to fix this properly, could you please:
Let me know if you need any help. |
|
Feedback addressed @ConradIrwin. Can you take another pass ? Thanks 👀 |
|
Thanks! released as gist 5.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275
This change is needed due to the deprecation warning/removal made by Github on the gist tool. See https://blog.github.com/2018-02-18-deprecation-notice-removing-anonymous-gist-creation/ for more info.