add --skip-empty to skip gisting empty files #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes defunkt#208 Option --skip-empty will skip any zero length files passes to gist. If all files are empty no gist will be created at all. test plan: - create two empty files 'empty1' and 'empty2'. - create a third file with some content 'content1'. % bin/gist empty1 empty2 content1 # should return error about an empty file % bin/gist --skip-empty empty1 empty2 content1 # should create gist with single file 'content1' % bin/gist --skip-empty empty1 empty2 # should return error/notice about all files empty no gist created % date | bin/gist # should create gist with date string
ConradIrwin
reviewed
Oct 9, 2017
lib/gist.rb
Outdated
| end | ||
| end | ||
|
|
||
| raise "All files were empty. No gist created." if json[:files].empty? && options[:skip_empty] |
There was a problem hiding this comment.
@phallstrom I think the program should not crash if you pass --skip-empty and an empty file. It should just silently exit successfully.
There was a problem hiding this comment.
Ah, I misread the original ticket thinking you wanted it to output details. Patch up.
|
Otherwise this looks good to me, thank you! |
|
Thanks @phallstrom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #208
Option --skip-empty will skip any zero length files passes to gist. If
all files are empty no gist will be created at all.
test plan: