allow negative real reserves #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative global real reserves are possible with uniswap v3. This will happen if you have two concentrated liquidity pools and a situation where a swap depletes one liquidity pool and then accesses liquidity for the other. In that case the total real reserve will be negative.
|
The test case to show the problem is to have one pool that has liquidity at all prices and then a second pool with concentrated liquidity. Once pool one depletes it should fall back on the second pool. However this will fail in the current swap because the total real reserve goes negative based on the curve from the first pool. |
|
Thx for this; I've been away on vacation, then was chasing down a pretty compelling AI problem, which I just resolved; I will be looking at this committing this early this week, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative global real reserves are possible with uniswap v3. This will happen if you have two concentrated liquidity pools and a situation where a swap depletes one liquidity pool and then accesses liquidity for the other. In that case the total real reserve will be negative.