refactor: optimism superchain erc20 redesign #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: update interfaces * fix: tests based on changes
agusduha
reviewed
Sep 25, 2024
| pragma solidity ^0.8.0; | ||
| pragma solidity 0.8.25; |
There was a problem hiding this comment.
We should leave interfaces with open pragma to simplify integrations
agusduha
reviewed
Sep 25, 2024
|
|
||
| /// @title IOptimismSuperchainERC20 | ||
| /// @notice Combines Solady's ERC20 interface with the OptimismSuperchainERC20Extension interface. | ||
| interface IOptimismSuperchainERC20 is IERC20Solady, IOptimismSuperchainERC20Extension { } |
There was a problem hiding this comment.
We should leave this interface, maybe changing IERC20Solady for IERC20 OZ interface
agusduha
reviewed
Sep 25, 2024
|
|
||
| /// @title ISuperchainERC20 | ||
| /// @notice Combines Solady's ERC20 interface with the SuperchainERC20Extensions interface. | ||
| interface ISuperchainERC20 is IERC20Solady, ISuperchainERC20Extensions, ISuperchainERC20Errors { } |
There was a problem hiding this comment.
Same here, but leaving it as it is because it uses solady
* feat: add check for supererc20 bridge on modifier * chore: update tests and interfaces
agusduha
reviewed
Sep 26, 2024
agusduha
reviewed
Sep 26, 2024
Comment on lines
+411
to
+420
| { | ||
| "inputs": [], | ||
| "name": "CallerNotL2ToL2CrossDomainMessenger", | ||
| "type": "error" | ||
| }, | ||
| { | ||
| "inputs": [], | ||
| "name": "InvalidCrossDomainSender", | ||
| "type": "error" | ||
| }, |
There was a problem hiding this comment.
Hmm the weth contract does not use these errors
idk if there is a better way to omit them, or maybe replace the current ones with these because they are more explicit, wdyt?
There was a problem hiding this comment.
I'm up to replace them since they're way more explicit
agusduha
previously approved these changes
Sep 26, 2024
0xDiscotech
changed the title
agusduha
added a commit
that referenced
this pull request
Oct 15, 2024
…-optimism#12321) * feat: add superchain erc20 bridge (#61) * feat: add superchain erc20 bridge * fix: interfaces and versions * refactor: optimism superchain erc20 redesign (#62) * refactor: use oz upgradeable erc20 as dependency * chore: update interfaces * fix: tests based on changes * refactor: remove op as dependency * feat: add check for supererc20 bridge on modifier * chore: update tests and interfaces * chore: update stack vars name on test * chore: remove empty gitmodules file * chore: update superchain weth errors * test: add superchain erc20 bridge tests (#65) * test: add superchain erc20 bridge tests * test: add optimism superchain erc20 beacon tests * test: remove unnecessary test * test: tests fixes * test: tests fixes * chore: update missing bridge on natspec (#69) * chore: update missing bridge on natspec * fix: natspecs --------- Co-authored-by: agusduha <agusnduha@gmail.com> * fix: remove superchain erc20 base (#70) * refactor: update isuperchainweth (#71) --------- Co-authored-by: agusduha <agusnduha@gmail.com> * feat: rename mint/burn and add SuperchainERC20 (#74) * refactor: rename mint and burn functions on superchain erc20 * chore: rename optimism superchain erc20 to superchain erc20 * feat: create optimism superchain erc20 contract * chore: update natspec and errors * fix: superchain erc20 tests * refactor: make superchain erc20 abstract * refactor: move storage and erc20 metadata functions to implementation * chore: update interfaces * chore: update superchain erc20 events * fix: tests * fix: natspecs * fix: add semmver lock and snapshots * fix: remove unused imports * fix: natspecs --------- Co-authored-by: 0xDiscotech <131301107+0xDiscotech@users.noreply.github.com> * fix: refactor zero check (#76) * fix: pre pr * fix: semver natspec check failure (#79) * fix: semver natspec check failure * fix: ignore mock contracts in semver natspec script * fix: error message * feat: add crosschain erc20 interface (#80) * feat: add crosschain erc20 interface * fix: refactor interfaces * fix: superchain bridge natspec (#83) * fix: superchain weth natspec (#84) Co-authored-by: 0xng <ng@defi.sucks> Co-authored-by: 0xParticle <particle@defi.sucks> Co-authored-by: gotzenx <78360669+gotzenx@users.noreply.github.com> * fix: stop inheriting superchain interfaces (#85) * fix: stop inheriting superchain interfaces * fix: move events and erros into the implementation * fix: make superchainERC20 inherits from crosschainERC20 * fix: superchain bridge rename (#86) * fix: fee vault compiler error (#87) * fix: remove unused imports * fix: refactor common errors (#90) * fix: refactor common errors * fix: remove unused version * fix: reuse unauthorized error (#92) * fix: superchain erc20 factory conflicts * fix: rename crosschain functions (#94) --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Co-authored-by: 0xng <ng@defi.sucks> Co-authored-by: 0xParticle <particle@defi.sucks> Co-authored-by: gotzenx <78360669+gotzenx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSES OPT-226
CLOSES OPT-227