Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests work on f25 #14

Merged
merged 4 commits into from
Jan 5, 2017
Merged

Conversation

romanofski
Copy link
Member

This now adds a few bugfixes and uses multiple Fedora versions to run the tests on. I've moved most of the code to run tests to the Makefile.

The F25 tests have one failing test, which I'm currently not sure if it's a regression in Encode or expected behvaiour (filed dankogai/p5-encode#88 for that).


# stable release
test_stable:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to just call this test_f25, makes it clear what it actually is. (I assume you mean "stable" as in the latest release of Fedora but that's not really clear).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh true.

Róman Joost added 4 commits January 5, 2017 15:34
This adds a dockertest target to conveniently run all tests on test_*
docker images.
This feature was possible by an experimental feature introduced in Perl
5.14, but removed in 5.23, thus causing an exception in Fedora 24 with a
Perl version of 5.24

Bug: 1410050
Instead of hardcoding the expectation which will pin us to specific file
versions, use the output of the file command to assert that it is
correctly working.
This adjusts the input string based on a possible regression with
Encode (see dankogai/p5-encode#88).
@@ -16,7 +16,7 @@ my @tests = (
[ 'ccc&d' => 'ccc&d' ], # HTML special char
[ 'cccd' => 'ccc[^V]d' ], # ctrl character
[ 'Muñoz' => 'Muñoz' ], # UTF-8 passthru
[ "Mu\361oz" => 'Muñoz' ], # GAH! non-utf8
[ "Mu\361loloz" => 'Muñloloz' ], # GAH! non-utf8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@sthaha sthaha merged commit 3e10ebe into default-to-open:master Jan 5, 2017
@romanofski romanofski deleted the tests_work_on_F25 branch January 6, 2017 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants