Tests work on f25 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danc86
reviewed
Jan 5, 2017
|
|
||
| # stable release | ||
| test_stable: |
There was a problem hiding this comment.
I would suggest to just call this test_f25, makes it clear what it actually is. (I assume you mean "stable" as in the latest release of Fedora but that's not really clear).
danc86
approved these changes
Jan 5, 2017
added 4 commits
January 5, 2017 15:34
This adds a dockertest target to conveniently run all tests on test_* docker images.
This feature was possible by an experimental feature introduced in Perl 5.14, but removed in 5.23, thus causing an exception in Fedora 24 with a Perl version of 5.24 Bug: 1410050
Instead of hardcoding the expectation which will pin us to specific file versions, use the output of the file command to assert that it is correctly working.
This adjusts the input string based on a possible regression with Encode (see dankogai/p5-encode#88).
romanofski
force-pushed
the
tests_work_on_F25
branch
from
37f9a7c
to
c33a016
Compare
danc86
approved these changes
Jan 5, 2017
| @@ -16,7 +16,7 @@ my @tests = ( | |||
| [ 'ccc&d' => 'ccc&d' ], # HTML special char | |||
| [ 'cccd' => 'ccc[^V]d' ], # ctrl character | |||
| [ 'Muñoz' => 'Muñoz' ], # UTF-8 passthru | |||
| [ "Mu\361oz" => 'Muñoz' ], # GAH! non-utf8 | |||
| [ "Mu\361loloz" => 'Muñloloz' ], # GAH! non-utf8 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now adds a few bugfixes and uses multiple Fedora versions to run the tests on. I've moved most of the code to run tests to the Makefile.
The F25 tests have one failing test, which I'm currently not sure if it's a regression in Encode or expected behvaiour (filed dankogai/p5-encode#88 for that).