Add presence to d.ts #338
Merged
Add presence to d.ts #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Presence interface Add presence field in Client
|
I don't understand for tests. |
|
Probably just a timeout, we have a few hundred e2e tests passing so its a bit unavoidable :$ Thanks for the PR, once it passes will merge. Says here your not yet a contributor, would you mind signing the CLA? https://deepstream.io/info/community/cla/ Thanks! |
|
Tests pass, woot! I'll be doing a release today, but can do another patch release once this is in |
|
No problem for the CLA, I will it. But your link redirect to https://deepstream.io/info/community/cla/form-ready with a content Not Found... |
|
Seems like a type-form regression =( I'll merge in and once form is back working will give you a nudge, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Presence interface
Add presence field in Client