Fix import deepspeed crash on PyTorch v2.3 + Python 3.12#7875
Open
tohtana wants to merge 3 commits intodeepspeedai:masterfrom
Open
Fix import deepspeed crash on PyTorch v2.3 + Python 3.12#7875tohtana wants to merge 3 commits intodeepspeedai:masterfrom
tohtana wants to merge 3 commits intodeepspeedai:masterfrom
Conversation
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1c74fb604
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import deepspeedraisesRuntimeError: Dynamo is not supported on Python 3.12+on PyTorch 2.3 + Python 3.12.The
jit_script_compatdecorator (introduced in #7835) callstorch.compile()unconditionally on PyTorch >= 2.0, but Dynamo support for Python 3.12 was only added in PyTorch 2.4.Multiple eager import chains trigger this decorator at import time, crashing before user code runs.
This PR adds a version gate to skip torch.compile on known-unsupported combinations, plus a double fallback (torch.compile → torch.jit.script → identity function) so the decorator won't crash.