Skip to content

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Apr 11, 2025

Related Issues

Proposed Changes:

  • remove the deprecated initialization parameters and simplify the components

How did you test it?

CI; refactored tests.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Apr 11, 2025
@coveralls
Copy link
Collaborator

coveralls commented Apr 11, 2025

Pull Request Test Coverage Report for Build 14404479415

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 90.316%

Files with Coverage Reduction New Missed Lines %
components/evaluators/llm_evaluator.py 6 94.78%
Totals Coverage Status
Change from base Build 14401135068: -0.01%
Covered Lines: 10660
Relevant Lines: 11803

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review April 11, 2025 13:39
@anakin87 anakin87 requested review from a team as code owners April 11, 2025 13:39
@anakin87 anakin87 requested review from dfokina and Amnah199 and removed request for a team April 11, 2025 13:39
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@anakin87 anakin87 merged commit 656fe6d into main Apr 15, 2025
32 checks passed
@anakin87 anakin87 deleted the llmevaluators-rm-deprecated-params branch April 15, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated api, api_key, and api_params from LLM Evaluator components
3 participants