Skip to content

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 12, 2023

Related Issues

  • fixes #issue-number

Proposed Changes:

% pre-commit install
% pre-commit autoupdate
% pre-commit run --all-files

Removed a comment about running mypy in pre-commit because of python/mypy#13916 and pypa/pip#12209 (comment)

How did you test it?

% pre-commit run --all-files

Notes for the reviewer

Checklist

@cclauss cclauss requested review from a team as code owners September 12, 2023 12:22
@cclauss cclauss requested review from dfokina and silvanocerza and removed request for a team September 12, 2023 12:22
@github-actions github-actions bot added topic:CI topic:DX Developer Experience proposal labels Sep 12, 2023
- id: mixed-line-ending # normalizes line endings
- id: no-commit-to-branch # prevents committing to main
- id: trailing-whitespace # trims trailing whitespace
args: [--markdown-linebreak-ext=md]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thanks! ❤️

@silvanocerza silvanocerza merged commit 23f7308 into deepset-ai:main Sep 12, 2023
@cclauss cclauss deleted the pre-commit_autoupdate_2023_09_12 branch September 12, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:CI topic:DX Developer Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants