Skip to content

fix: allow reserved names in tool output mappings - #13159

Open
Vietpr wants to merge 1 commit into
deepset-ai:mainfrom
Vietpr:fix-13109-tool-output-config
Open

Vietpr wants to merge 1 commit into
deepset-ai:mainfrom
Vietpr:fix-13109-tool-output-config

Conversation

@Vietpr

@Vietpr Vietpr commented Oct 7, 2026

Copy link
Copy Markdown

Related Issues

Proposed Changes

  • Allow 'source', 'handler', and 'raw_result' as names in multi-output 'outputs_to_string' configurations.
  • Add regression tests and a release note.

How did you test it?

  • Unit tests passed.
  • Pre-commit checks passed.

@Vietpr
Vietpr requested a review from a team as a code owner October 7, 2026 13:06
@Vietpr
Vietpr requested review from bogdankostic and removed request for a team October 7, 2026 13:06
@vercel

vercel Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

@Vietpr is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

CLAassistant commented Oct 7, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @Vietpr, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

@HaystackBot
HaystackBot removed the request for review from bogdankostic October 7, 2026 14:32
@HaystackBot HaystackBot added the cla-pending PR is in draft until the contributor signs the CLA label Oct 7, 2026
@HaystackBot
HaystackBot marked this pull request as draft October 7, 2026 14:32
@HaystackBot
HaystackBot marked this pull request as ready for review October 9, 2026 03:40
@HaystackBot HaystackBot removed the cla-pending PR is in draft until the contributor signs the CLA label Oct 9, 2026
@HaystackBot

Copy link
Copy Markdown
Contributor

Thanks for signing the CLA, @Vietpr! 🎉 This PR is now ready for review again and the reviewer has been re-assigned.

@Vietpr
Vietpr force-pushed the fix-13109-tool-output-config branch from b802cea to 34b6a77 Compare October 10, 2026 11:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool outputs_to_string fails when multi-output tools use "source", "handler", or "raw_result" as output keys

3 participants