Skip to content

fix: recognize tabs after Markdown header prefixes - #13104

Open
sunlishuo25 wants to merge 1 commit into
deepset-ai:mainfrom
sunlishuo25:fix/markdown-tab-headings
Open

sunlishuo25 wants to merge 1 commit into
deepset-ai:mainfrom
sunlishuo25:fix/markdown-tab-headings

Conversation

@sunlishuo25

Copy link
Copy Markdown

Related Issues

No existing issue.

Proposed Changes:

MarkdownHeaderSplitter ignores headings such as #\tGuide, leaving their sections together and losing header metadata used by filtering. Accept spaces or tabs after the opening hashes, as allowed by ATX heading syntax.

Add regression coverage for heading hierarchy, both keep_headers modes, secondary splitting, code fences, and synchronous/asynchronous indexing followed by section retrieval. Update the docstring, documentation, and release note.

How did you test it?

The regressions fail on the original source (9 failed, 71 passed). The targeted splitter, converter, writer, and filter retriever unit suites pass after the fix (111 passed, 1 integration test deselected) on Python 3.10. Scoped mypy and pre-commit checks pass.

Tests used a local Hatch environment with runtime dependencies and lightweight test tools. The complete official test environment and CI were not run.

Notes for the reviewer

Developed with GPT assistance.

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have added unit tests and updated the docstrings.
  • I've used a conventional commit type for the PR title.
  • I have documented my code.
  • I have added a release note file.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

@sunlishuo25 is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@sunlishuo25
sunlishuo25 marked this pull request as ready for review October 4, 2026 16:32
@sunlishuo25
sunlishuo25 requested a review from a team as a code owner October 4, 2026 16:32
@sunlishuo25
sunlishuo25 requested review from bogdankostic and removed request for a team October 4, 2026 16:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant