feat: add async support for Chroma #1697
Open
+571
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
added
async
version of the followingChromaDocumentStore
methods:_ensure_initialized_async
count_documents_async
filter_documents_async
write_documents_async
delete_documents_async
search_async
search_embeddings_async
added
run_async
methods forChromaQueryTextRetriever
andChromaEmbeddingRetriever
How did you test it?
test_document_store_async.py
that tests methods aboveNotes for the reviewer
I still need to check a couple of tests in
test_document_store_async.py
and write tests for retrievers, will be done with next commitsChecklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.