Skip to content

fix: do not validate name if overwrite set to true #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025

Conversation

faymarie
Copy link
Contributor

@faymarie faymarie commented Jun 12, 2025

Related Issues

  • when overwriting existing pipelines, the validation would always warn about pipeline/index already existing
  • Fixed by excluding the name from the validation call in case of overwrite
  • Fixes import of PipelineOutputType

Proposed Changes?

How did you test it?

Notes for the reviewer

Screenshots (optional)

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@faymarie faymarie requested a review from a team as a code owner June 12, 2025 08:18
@faymarie faymarie requested a review from tstadel June 12, 2025 08:18
Copy link

github-actions bot commented Jun 12, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  deepset_cloud_sdk/workflows/pipeline_client
  pipeline_service.py
Project Total  

This report was generated by python-coverage-comment-action

@@ -14,6 +14,7 @@
PipelineConfig,
PipelineInputs,
PipelineOutputs,
PipelineOutputType,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to add this in d370b98

@faymarie faymarie added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@faymarie faymarie added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@faymarie faymarie added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit 7a94f45 Jun 12, 2025
9 checks passed
@faymarie faymarie deleted the fix/no-name-validation-on-overwrite branch June 12, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants